|From:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|To:||Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>|
|Cc:||Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: BUG: pg_dump generates corrupted gzip file in Windows|
|Views:||Raw Message | Whole Thread | Download mbox|
> That patch looks reasonable to me, will push.
On closer inspection, the patch did contain a bug: it tested for
compression being active with "compression > 0", which is the wrong
thing --- everyplace else in pg_dump tests with "compression != 0".
This is important because Z_DEFAULT_COMPRESSION is -1. The net
effect is that the patch would have appeared to fix the bug when
writing "-Z1".."-Z9", but not when writing just "-Z". Possibly
this explains why Kuntal couldn't confirm success at one point
Pushed with that correction and some wordsmithing on the comment.
regards, tom lane
|Next Message||Dilip Kumar||2017-06-19 15:09:19||Re: psql's \d and \dt are sending their complaints to different output files|
|Previous Message||Tom Lane||2017-06-19 14:40:59||Re: BUG: pg_dump generates corrupted gzip file in Windows|