From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: BUG: pg_dump generates corrupted gzip file in Windows |
Date: | 2017-06-19 14:40:59 |
Message-ID: | 28799.1497883259@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> writes:
> On Mon, Jun 19, 2017 at 12:25 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>> On Mon, Jun 19, 2017 at 11:42 AM, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
>>> On Fri, Mar 24, 2017 at 10:16 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>>> Why not? I mean, if there's code there to force the output into
>>>> binary mode, does that not work for the -Fc case? And if it does work
>>>> for the -Fc case, then why doesn't it also work for -Z9?
>>> I have re-verified the patch with the help of my colleague 'Neha
>>> Sharma' on Windows server 2008 R2 machine and the fix looks to be
>>> working fine. With the help of attached patch,
>> Did you intended to attach the patch to this e-mail or are you
>> referring to Kuntal's patch up thread? If later, then it is better to
>> mention the link of mail which has a patch that you have verified.
> I am referring to Kuntal's patch upthread. The link for the email
> having the patch is,
> https://www.postgresql.org/message-id/CAGz5QCJPvbBjXAmJuGx1B_41yVCetAJhp7rtaDf7XQGWuB1GSw%40mail.gmail.com
That patch looks reasonable to me, will push.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-06-19 15:09:18 | Re: BUG: pg_dump generates corrupted gzip file in Windows |
Previous Message | Tom Lane | 2017-06-19 14:31:04 | Re: Setting pd_lower in GIN metapage |