Re: Something flaky in the "relfilenode mapping" infrastructure

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Something flaky in the "relfilenode mapping" infrastructure
Date: 2014-03-28 20:55:49
Message-ID: 30368.1396040149@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> I don't think it's necessary. As far as I understand LATERAL, a join to
> a function returning NULL will still return the row. So, the test now
> would only test whether there are rows in pg_class which seems a bit
> pointless.

Yeah, after looking closer I'd come to the same conclusion. If the
lateral function call could generate zero rows it'd perhaps be a risk,
but not in this formulation.

Will commit in a moment.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2014-03-28 21:19:30 Re: Composite Datums containing toasted fields are a bad idea(?)
Previous Message Andres Freund 2014-03-28 20:52:00 Re: Something flaky in the "relfilenode mapping" infrastructure