Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Add amcheck extension to contrib.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql: Add amcheck extension to contrib.
Date: 2017-03-13 19:45:01
Message-ID: 30354.1489434301@sss.pgh.pa.us (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-committerspgsql-hackers
Andres Freund <andres(at)anarazel(dot)de> writes:
> Add amcheck extension to contrib.

axolotl just failed on this:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=axolotl&dt=2017-03-13%2017%3A49%3A24

***************
*** 78,86 ****
  
  -- make sure we don't have any leftover locks
  SELECT * FROM pg_locks WHERE relation IN ('bttest_a_idx'::regclass, 'bttest_b_idx'::regclass);
!  locktype | database | relation | page | tuple | virtualxid | transactionid | classid | objid | objsubid | virtualtransaction | pid | mode | granted | fastpath 
! ----------+----------+----------+------+-------+------------+---------------+---------+-------+----------+--------------------+-----+------+---------+----------
! (0 rows)
  
  COMMIT;
  -- cleanup
--- 78,87 ----
  
  -- make sure we don't have any leftover locks
  SELECT * FROM pg_locks WHERE relation IN ('bttest_a_idx'::regclass, 'bttest_b_idx'::regclass);
!  locktype | database | relation | page | tuple | virtualxid | transactionid | classid | objid | objsubid | virtualtransaction |  pid  |      mode       | granted | fastpath 
! ----------+----------+----------+------+-------+------------+---------------+---------+-------+----------+--------------------+-------+-----------------+---------+----------
!  relation |    57562 |    57573 |      |       |            |               |         |       |          | 4/29               | 20342 | AccessShareLock | t       | t
! (1 row)
  
  COMMIT;
  -- cleanup


I could be wrong, but the most obvious explanation for this failure is
that autovacuum had a lock on the table or index when we looked.
Even if that isn't why axolotl failed in this particular case, I think
it's dead certain that we will see such failures from time to time
if this test script isn't tightened up.  IIUC what the test is trying
to look for, I think adding "AND pid = pg_backend_pid()" to this query
would be an appropriate fix.

			regards, tom lane


In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2017-03-13 19:46:51
Subject: Re: Should buffer of initialization fork have a BM_PERMANENT flag
Previous:From: Alvaro HerreraDate: 2017-03-13 19:34:03
Subject: Re: delta relations in AFTER triggers

pgsql-committers by date

Next:From: Peter EisentrautDate: 2017-03-13 19:45:14
Subject: pgsql: Fix compiler warning
Previous:From: Peter EisentrautDate: 2017-03-13 19:44:14
Subject: pgsql: Change xlog to WAL in some error messages

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group