Re: pgsql: Add optional parameter to PG_TRY() macros

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> There's no public discussion about it, and I didn't think it critical
> enough to open a new thread about. I believe the newly added
> PG_PERL_TRY() macros would need a ##__VA_ARGS__ suffix on all the
> local variables, else we'd get shadow warnings if we ever nested
> PG_PERL_TRYs.

We would get some warnings for that anyway, because we don't have the
ability to change the name of the variable that Perl's dJMPENV macro
creates. So I didn't bother for the variables that are specific to
PG_PERL_TRY. The case I was mainly worried about was not gettimg
shadow warnings for PG_PERL_TRY nested within PG_TRY, which is a
pattern that exists now; so it's worth having the ##__VA_ARGS__
business on the variables that would conflict with PG_TRY.

regards, tom lane