BUG in XLogRecordAssemble

From: "Zhang Zq" <zqzhangmail(at)163(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: BUG in XLogRecordAssemble
Date: 2015-05-04 16:04:09
Message-ID: 3020aba3.1f49f.14d1fab99c8.Coremail.zqzhangmail@163.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

hi,
I found the code in 'backend/access/transam/xloginsert.c' as that:
XLogRecordAssemble:
if (prev_regbuf && RelFileNodeEquals(regbuf->rnode, prev_regbuf->rnode))
{
samerel = true;
bkpb.fork_flags |= BKPBLOCK_SAME_REL;
prev_regbuf = regbuf;
}
else
samerel = false;

There is the only place that prev_regbuf is assigned, so prev_regbuf will never be assigned.
The patch will fix it, Thanks.
Zhang Zq

Attachment Content-Type Size
XLogRecordAssemble.patch application/octet-stream 677 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sandro Santilli 2015-05-04 17:11:35 Unexpected speed PLAIN vs. MAIN
Previous Message Merlin Moncure 2015-05-04 14:58:30 Re: cache invalidation for PL/pgsql functions