Re: Garbled comment in postgresGetForeignJoinPaths

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Garbled comment in postgresGetForeignJoinPaths
Date: 2017-08-16 18:16:43
Message-ID: 302.1502907403@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Aug 16, 2017 at 12:31 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> --> * reconstruct the row for EvalPlanQual(). Find an alternative local path
>> Should the marked line simply be deleted? If not, what correction is
>> appropriate?

> Hmm, wow. My first thought was that it should just say
> "reconstructing" rather than "reconstruct", but on further reading I
> think you might have the right idea.

The current text of the comment dates to commit 177c56d60, and looking at
that commit makes it pretty clear that the line I'm complaining of
belonged to the previous text; it evidently just missed getting deleted.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-08-16 18:40:41 Re: Logical replication: stuck spinlock at ReplicationSlotRelease
Previous Message Tom Lane 2017-08-16 18:09:08 Re: Atomics for heap_parallelscan_nextpage()