| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, postgresql(at)taljaren(dot)se, pgsql-hackers(at)lists(dot)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: BUG #17717: Regression in vacuumdb (15 is slower than 10/11 and possible memory issue) |
| Date: | 2023-01-06 17:53:07 |
| Message-ID: | 3018167.1673027587@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> On Thu, Dec 29, 2022 at 03:29:15PM -0500, Tom Lane wrote:
>> I tried to make a patch along these lines, and soon hit a stumbling
>> block: ONLY is a fully-reserved SQL keyword. I don't think this
>> syntax is attractive enough to justify requiring people to
>> double-quote the option, so we are back to square one. Anybody
>> have a different suggestion?
> ... adding both SKIP_DATABASE_STATS and ONLY_DATABASE_STATS might be the
> best bet.
Nobody has proposed a different bikeshed color, so I'm going to
proceed with that syntax. I'll incorporate the parallel-machinery
fix from your patch and push to HEAD only (since it's hard to argue
this isn't a new feature).
This needn't foreclose pursuing the various ideas about making
vac_update_datfrozenxid faster; but none of those would eliminate
the fundamental O(N^2) issue AFAICS.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2023-01-06 18:29:48 | BUG #17738: There is a typo on your website |
| Previous Message | Alex Richman | 2023-01-06 16:35:30 | Re: Logical Replica ReorderBuffer Size Accounting Issues |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2023-01-06 18:20:23 | Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert |
| Previous Message | Bharath Rupireddy | 2023-01-06 17:41:26 | Re: Add a new pg_walinspect function to extract FPIs from WAL records |