Re: BTREE_BUILD_STATS build is broken

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BTREE_BUILD_STATS build is broken
Date: 2016-05-24 14:31:20
Message-ID: 30145.1464100280@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Geoghegan <pg(at)heroku(dot)com> writes:
> On Mon, May 23, 2016 at 8:09 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> (More generally, is there a better answer for that problem?)

> My unpublished parallel B-Tree index build patch will move everything
> to do with index builds into nbtsort.c.

Yeah, I was kind of wondering why tcopprot.h had anything to do with
sorting or indexing behavior at all. It seems like relocating the
declarations would be a better long-term answer.

> Short term, I guess the best solution is to just have a pgrminclude
> directive in both files.

If we're intending to get rid of the dependency, I won't bother with
adding the other directive. I don't believe there are any near-term
plans to run pgrminclude.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message digoal 2016-05-24 14:41:46 BUG #14155: bloom index error with unlogged table
Previous Message Jim Nasby 2016-05-24 14:23:27 Re: Lets (not) break all the things. Was: [pgsql-advocacy] 9.6 -> 10.0