Re: pg_amcheck contrib application

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Amul Sul <sulamul(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_amcheck contrib application
Date: 2021-03-15 17:04:14
Message-ID: 3012106.1615827854@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Looks like we're not quite out of the woods, as hornet and tern are
still unhappy:

# Failed test 'pg_amcheck excluding all corrupt schemas status (got 2 vs expected 0)'
# at t/003_check.pl line 498.

# Failed test 'pg_amcheck excluding all corrupt schemas stdout /(?^:^$)/'
# at t/003_check.pl line 498.
# 'heap table "db1"."pg_catalog"."pg_statistic", block 2, offset 1, attribute 27:
# final toast chunk number 0 differs from expected value 1
# heap table "db1"."pg_catalog"."pg_statistic", block 2, offset 1, attribute 27:
# toasted value for attribute 27 missing from toast table
# '
# doesn't match '(?^:^$)'
# Looks like you failed 2 tests of 60.
[12:18:06] t/003_check.pl ...........
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/60 subtests

These animals have somewhat weird alignment properties: MAXALIGN is 8
but ALIGNOF_DOUBLE is only 4. I speculate that that is affecting their
choices about whether an out-of-line TOAST value is needed, breaking
this test case.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Mlodgenski 2021-03-15 17:05:25 Re: Parser Hook
Previous Message Jim Mlodgenski 2021-03-15 17:02:20 Re: Parser Hook