| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Hannu Krosing <hannuk(at)google(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Vitaly Davydov <v(dot)davydov(at)postgrespro(dot)ru>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Support logical replication of DDLs, take2 |
| Date: | 2026-04-29 12:10:17 |
| Message-ID: | 2oh4o4zvj2jreituesxgglmnseo2m2brffms3lvao6mseemto6@32v67ejhxlht |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
Hi,
On 2026-04-29 10:07:04 +0200, Hannu Krosing wrote:
> On Wed, Apr 29, 2026 at 5:39 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> > I am trying to understand your idea. If we are trying to deparse from
> > an actual system table using a snapshot, why don't we just use the
> > WAL? I mean, the WAL should contain the actual catalog modifications
> > it has made.
>
> We have the full data in the catalog and we would likely need catalog
> queries for any change, even when de-parsing the tree.
>
> And we should not add the extra load on the original DDL side, just as
> we don't for DML.
That can't be a relevant cost compared to everything else.
> At most we could just serialize the statement tree into the WAL,
> though even that may be an overkill if we can get the change from
> existing records.
>
> - insert new row in pg_class --> extract the CREATE TABLE (or INDEX, or ...)
> - update row in pg_class or insert, update or delete a row in
> pg_attribute --> extract ALTER TABLE
> - except when it just updates relfilenod --> extract TRUNCATE
> - delete row in pg_class --> DROP TABLE
> - dml on pg_constraint --> ALTER TABLE
>
> ... etc
That doesn't work in the general case, think of
ALTER TABLE ... ALTER COLUMN ... TYPE foo USING (...)
There's a big difference between USING(foo::int8) and USING (pg_size_bytes(foo))
but it's nowhere visible in the WAL.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adrian Klaver | 2026-04-29 17:41:33 | Re: Table and publisher/subscriber ownership |
| Previous Message | Dilip Kumar | 2026-04-29 11:29:26 | Re: Support logical replication of DDLs, take2 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2026-04-29 12:10:32 | Re: Property graph: fix error handling when dropping non-existent label property |
| Previous Message | shveta malik | 2026-04-29 11:32:13 | Re: Include schema-qualified names in publication error messages. |