Re: [PATCH] Runtime control of CLOBBER_CACHE_ALWAYS

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Runtime control of CLOBBER_CACHE_ALWAYS
Date: 2021-01-06 10:23:45
Message-ID: 2ffff2f9-8182-8ff2-0f29-15c61924a40e@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-01-06 00:30, Craig Ringer wrote:
> Perhaps debug_invalidate_system_caches_always ? It's a bit long but we
> use the debug prefix elsewhere too.

Committed with that name.

In your original patch, this hunk in pg_config_manual.h:

+ * You can define these by editing pg_config_manual.h but it's usually
+ * sufficient to pass CFLAGS to configure, e.g.
+ *
+ * ./configure --enable-debug --enable-cassert CFLAGS="-DUSE_VALGRIND"
+ *
+ * The flags are persisted in Makefile.global so they will be correctly
+ * applied to extensions, including those built by PGXS.

I don't think that necessarily works for all settings. Maybe we should
make a pass through it and ensure it all works sensibly, but that seems
like a separate project.

--
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-01-06 11:42:53 Re: Incorrect allocation handling for cryptohash functions with OpenSSL
Previous Message Amit Kapila 2021-01-06 10:09:50 Re: Single transaction in the tablesync worker?