| From: | David Geier <geidav(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reduce build times of pg_trgm GIN indexes |
| Date: | 2026-01-09 12:10:38 |
| Message-ID: | 2ffdae69-7242-4151-82d0-90d82e045d89@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
> Hi!
> patches 0003, 0004 & 0008 applies with whitespace errors.
>
I've fixed the white space errors. See v2 of the patch set in [1].
> I did run benchmarks of my VM using your data. v1-0001 solely improves
> runtime by 4-5%. v2-0002 does not show runtime improvement for me.
> With parallel GIN build, performance gains are 2-3 % for 2 workers and
> not noticeable after that.
>
> I will try to run some more benchmarks on this.
Thanks. I've also included the delta for each patch in [1]. I would be
curious what you measure, especially for patch 0004, where I curiously
measured a regression.
[1]
https://www.postgresql.org/message-id/e5dd01c6-c469-405d-aea2-feca0b2dc34d%40gmail.com
--
David Geier
| From | Date | Subject | |
|---|---|---|---|
| Next Message | songjinzhou | 2026-01-09 12:50:56 | Re: file_fdw: Support multi-line HEADER option. |
| Previous Message | David Geier | 2026-01-09 12:06:42 | Re: Reduce build times of pg_trgm GIN indexes |