Re: pgsql: Allow 'sslkey' and 'sslcert' in postgres_fdw user mappings

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Allow 'sslkey' and 'sslcert' in postgres_fdw user mappings
Date: 2020-01-20 09:00:34
Message-ID: 2fb2a879-725b-57c1-bd15-a9111a03416c@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 1/20/20 2:48 AM, Craig Ringer wrote:
> On Thu, 9 Jan 2020 at 22:38, Christoph Berg <myon(at)debian(dot)org
> <mailto:myon(at)debian(dot)org>> wrote:
>
> Re: Robert Haas 2020-01-09
> <CA+TgmoZEjyv_PD=2cinkbDA_chyLNAcBPL_9bKJQ6bc=nw+FHA(at)mail(dot)gmail(dot)com
> <mailto:nw%2BFHA(at)mail(dot)gmail(dot)com>>
> > Does this mean that a non-superuser can induce postgres_fdw to
> read an
> > arbitrary file from the local filesystem?
>
> Yes, see my comments in the "Allow 'sslkey' and 'sslcert' in
> postgres_fdw user mappings" thread.
>
>
> Ugh, I misread your comment.
>
> You raise a sensible concern.
>
> These options should be treated the same as the proposed option to
> allow passwordless connections: disallow creation or alteration of FDW
> connection strings that use them by non-superusers. So a superuser can
> define a user mapping that uses these options, but normal users may not.
>
>

Already done.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-01-20 17:57:43 pgsql: Fix pg_dump's sigTermHandler() to use _exit() not exit().
Previous Message Heikki Linnakangas 2020-01-20 08:41:50 pgsql: Fix crash in BRIN inclusion op functions, due to missing datum c

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2020-01-20 09:17:50 Re: Unicode normalization SQL functions
Previous Message Peter Eisentraut 2020-01-20 08:59:34 Re: Add support for automatically updating Unicode derived files