stray references to SubscriptRef type

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: stray references to SubscriptRef type
Date: 2025-09-09 14:24:02
Message-ID: 2eaa45e3-efc5-4d75-b082-f8159f51445f@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

There are several mentions in code comments of a SubscriptRef type, but
that type does not exist and AFAICT never existed. (Perhaps it existed
in in-development code at some point.)

I think in several of those cases this clearly meant the type
SubscriptingRef instead. But the mentions in
src/include/nodes/subscripting.h probably meant the various sbs_* functions.

If so, it would also be useful perhaps to document the leakproof
expectations of the other sbs_* functions (sbs_fetch_old and
sbs_check_subscripts).

See attached patch for my solution so far.

Attachment Content-Type Size
0001-Fix-stray-references-to-SubscriptRef.patch text/plain 4.4 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2025-09-09 14:30:01 Re: Eager aggregation, take 3
Previous Message Robert Haas 2025-09-09 14:20:14 Re: Eager aggregation, take 3