a problem about XLogReader callback system

From: "Wang, Shenhao" <wangsh(dot)fnst(at)cn(dot)fujitsu(dot)com>
To: "alvherre(at)alvh(dot)no-ip(dot)org" <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: a problem about XLogReader callback system
Date: 2020-09-28 06:28:37
Message-ID: 2e9eed7d84fe4254bb6df1121d05caab@G08CNEXMBPEKD06.g08.fujitsu.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, hackers

I have a problem about XLogReader callback system

In xlog.c, function StartupXLOG

xlogreader =
XLogReaderAllocate(wal_segment_size, NULL,
XL_ROUTINE(.page_read = &XLogPageRead,
.segment_open = NULL,
.segment_close = wal_segment_close),
&private);

XLogPageReader uses readFile to store the fd, and I can't find any location to set the value of seg.ws_file.
Is it necessary to set a segment_close callback?

Best regards
Wang

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tang, Haiying 2020-09-28 06:42:36 remove useless returns
Previous Message tsunakawa.takay@fujitsu.com 2020-09-28 04:58:19 RE: Transactions involving multiple postgres foreign servers, take 2