Re: pgsql: psql: Add test for query canceling

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: psql: Add test for query canceling
Date: 2021-08-26 06:39:31
Message-ID: 2e765fec-219a-378f-a035-f85c95ff3bff@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 25.08.21 07:37, Fabien COELHO wrote:
> I finally came around to have a look at the patch.
>
> For the issue raised above, I can see that the file could be created but
> not yet written, but as the patch waits for the file to be non zero,
> ISTM that the probability of a torn write of a single integer by echo is
> so remote that we could let it as that?
>
> Attached a version with the slurping in the loop anyway.

It looks like this fixed it. Thanks all.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2021-08-26 07:00:32 pgsql: Fix handling of partitioned index in RelationGetNumberOfBlocksIn
Previous Message Dilip Kumar 2021-08-26 06:17:34 Re: Separate out FileSet from SharedFileSet (was Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o)