Re: Logical Replication WIP

From: Petr Jelinek <petr(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Logical Replication WIP
Date: 2016-09-06 19:04:56
Message-ID: 2dec6387-8da0-2324-3675-6b1d82bc2e0b@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06/09/16 20:14, Peter Eisentraut wrote:
> On 9/3/16 5:14 AM, Petr Jelinek wrote:
>>> What are the BKI_ROWTYPE_OID assignments for? Are they necessary
>>>> here? (Maybe this was just copied from pg_subscription?)
>>>>
>> Yes they are.
>
> Please explain/document why. It does not match other catalogs, which
> either use it for relcache initialization or because they are shared
> catalogs. (I'm not sure of the details, but this one clearly looks
> different.)
>

Erm, I meant yes they are just copied and I will remove them (I see how
my answer might been confusing given that you asked multiple questions,
sorry).

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2016-09-06 19:08:33 Re: Tuplesort merge pre-reading
Previous Message Josh Berkus 2016-09-06 19:03:41 Re: Quorum commit for multiple synchronous replication.