| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, amitlangote09(at)gmail(dot)com |
| Cc: | robertmhaas(at)gmail(dot)com, m(dot)milyutin(at)postgrespro(dot)ru, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Partitioned tables and relfilenode |
| Date: | 2017-03-31 07:17:05 |
| Message-ID: | 2dec1acb-6e2f-5aa5-0e26-fcc172ce9359@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Horiguchi-san,
On 2017/03/31 15:50, Kyotaro HORIGUCHI wrote:
> At Thu, 30 Mar 2017 20:58:35 +0900, Amit Langote wrote:
>> Updated patch attached.
>
> Thank you.
>
> - Applies cleanly on master (f90d23d)
> - Compiled without error
> - Code seems fine.
> - Documentaion seems fine.. for me.
> - Passes regression test.
> - Leaving the ALTER-on-toast.* problem is fine for me.
Thanks for the review.
> The regression contains the tests to fail with several reloptions
> only for partitioned tables. Are they still required even though
> it is now in the same framework with other kind of reloptions?
Hmm, maybe we don't really need those tests, so removed.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Do-not-allocate-storage-for-partitioned-tables.patch | text/x-diff | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2017-03-31 07:33:12 | Parallel query execution with SPI |
| Previous Message | Tsunakawa, Takayuki | 2017-03-31 07:10:44 | [bug fix] Savepoint-related statements terminates connection |