Re: Make stream_prepare an optional callback

From: Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Make stream_prepare an optional callback
Date: 2021-03-09 08:25:43
Message-ID: 2db14042-d6cc-8427-3635-5286902bdd27@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09.03.21 07:40, Amit Kapila wrote:
> Sounds reasonable to me. I also don't see a reason why we need to make
> this a necessary callback. Some plugin authors might just want 2PC
> without streaming support.

Sounds okay to me. Probably means we'll have to check for this callback
and always skip the prepare for streamed transactions, w/o even
triggering filter_prepare, right? (Because the extension requesting not
to filter it, but not providing the corresponding callback does not make
sense.)

If you're going to together a patch Ajin, I'm happy to review.

Best Regards

Markus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2021-03-09 08:27:50 Re: Implementing Incremental View Maintenance
Previous Message Dilip Kumar 2021-03-09 08:22:37 Re: [HACKERS] Custom compression methods