| From: | miyake_kouta <miyake_kouta(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] pgbench: Bug fix for the -d option |
| Date: | 2021-03-02 02:52:33 |
| Message-ID: | 2d3bf5175b3664fd4e7f4bcb379c36f4@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2021-02-26 20:30, Michael Paquier wrote:
> By the way, I can help but wonder why pgbench has such a different
> handling for the user name, fetching first PGUSER and then looking at
> the options while most of the other binaries use get_user_name(). It
> seems to me that we could simplify the handling around "login" without
> really impacting the usefulness of the tool, no?
Hi.
Thank you for your comment.
I modified the patch based on other binaries.
In this new patch, if there is a $PGUSER, then it's set to login.
If not, get_user_name_or_exit is excuted.
Plese let me know what you think about this change.
--
Kota Miyake
| Attachment | Content-Type | Size |
|---|---|---|
| v02_pgbench_debuglogger.patch | text/x-diff | 671 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | miyake_kouta | 2021-03-02 02:57:37 | [PATCH] psql : Improve code for help option |
| Previous Message | vignesh C | 2021-03-02 02:50:33 | Re: repeated decoding of prepared transactions |