Re: Why do we have perl and sed versions of Gen_dummy_probes?

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>, Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz>, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>
Subject: Re: Why do we have perl and sed versions of Gen_dummy_probes?
Date: 2021-05-10 09:44:44
Message-ID: 2cad0262-83e2-db29-6e12-83a976f84641@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 07.05.21 20:31, Andrew Dunstan wrote:
> On 5/7/21 1:20 PM, Andres Freund wrote:
>> On 2021-05-07 11:19:02 -0400, Andrew Dunstan wrote:
>>> Here's a patch that adds the README and also adds a Makefile recipe for
>>> regenerating Gen_dummy_probes.pl after the sed script is changed. On my
>>> system at least the recipe is idempotent.
>> Nice! Thanks for this work.
>
> de nada. pushed.

This recipe doesn't produce a Gen_dummy_probes.pl that matches exactly
the one that is there now. If this is going to be the preferred method,
then we should generate it once so that it matches going forward.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nitin Jadhav 2021-05-10 09:45:31 Fix of file path in the file comments
Previous Message Dilip Kumar 2021-05-10 09:38:56 Re: GetSubscriptionRelations declares too many scan keys