Re: Fix missing space before WHERE in `GRAPH_TABLE` deparse

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Chauhan Dhruv <chauhandhruv351(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Fix missing space before WHERE in `GRAPH_TABLE` deparse
Date: 2026-08-03 08:33:13
Message-ID: 2ca43a17-6fa8-4602-aa5b-ae9c6c575162@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 30.07.26 13:20, Chauhan Dhruv wrote:
> Thanks for the review :)
>
> > Instead of creating another view, I would try to add the WHERE clause
> in customer_us definition itself.
>
> Great idea! Done in attached v2.  The whole-pattern WHERE clause is now
> part of the existing
> customers_us definition, so there is no extra view.  The predicate
> (p.price > 0) is deliberately trivial; as you say, the view is not
> queried anywhere, so only its deparsed definition matters.
> I also updated the comment above the view to mention that it covers
> WHERE clauses both on pattern elements and on the whole pattern.
>
> > Further, we usually don't drop any objects created by this test so
> that they can be tested in the 002_pg_upgrade test. Please observe that
> customer_us view is not dropped
>
> hmm makes sense, will take care of it
>
> v2 patch is attached.

Committed, thanks.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2026-08-03 08:44:08 Re: A new C function `get_partition_root`.
Previous Message Alexander Korotkov 2026-08-03 08:32:31 Re: Asynchronous MergeAppend