| From: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, "Amit Langote" <amitlangote09(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
| Subject: | RE: Determine parallel-safety of partition relations for Inserts |
| Date: | 2021-02-02 01:54:37 |
| Message-ID: | 2c70b3dd4ce947b98b37d47e19434685@G08CNEXMBPEKD05.g08.fujitsu.local |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> > IMO, It seems more readable to extract all the check that we can do
> > before the safety-check and put them in the new function.
> >
> > Please consider it for further review.
> >
>
> I've updated your v2 patches and altered some comments and documentation
> changes (but made no code changes) - please compare against your v2 patches,
> and see whether you agree with the changes to the wording.
> In the documentation, you will also notice that in your V2 patch, it says
> that the "parallel_dml_enabled" table option defaults to false.
> As it actually defaults to true, I changed that in the documentation too.
Hi greg,
Thanks a lot for the document update, LGTM.
Attaching v4 patches with the changes:
* fix some typos in the code.
* store partitioned reloption in a separate struct PartitionedOptions,
making it more standard and easier to expand in the future.
Please consider it for further review.
Best regards,
Houzj
| Attachment | Content-Type | Size |
|---|---|---|
| v4_0001-guc-option-enable_parallel_dml-src.patch | application/octet-stream | 3.7 KB |
| v4_0002-guc-option-enable_parallel_dml-doc-and-test.patch | application/octet-stream | 5.1 KB |
| v4_0003-reloption-parallel_dml-src.patch.patch | application/octet-stream | 8.9 KB |
| v4_0004-reloption-parallel_dml-test-and-doc.patch | application/octet-stream | 6.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2021-02-02 02:10:24 | Re: [PATCH] Doc: improve documentation of oid columns that can be zero. (correct version) |
| Previous Message | Euler Taveira | 2021-02-02 01:51:33 | Re: a verbose option for autovacuum |