Re: run pgindent on a regular basis / scripted manner

On 2023-05-17 We 17:10, Tom Lane wrote:
> I wrote:
>> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>>> I doubt there's something like that.
>> I had a read-through of the latest version's man page, and found
>> this promising-looking entry:
>> -boc, --break-at-old-comma-breakpoints
> Sadly, this seems completely not ready for prime time. I experimented
> with it under perltidy 20230309, and found that it caused hundreds
> of kilobytes of gratuitous changes that don't seem to have a direct
> connection to the claimed purpose. Most of these seemed to be from
> forcing a line break after a function call's open paren, like
>
> @@ -50,10 +50,12 @@ detects_heap_corruption(
> #
> fresh_test_table('test');
> $node->safe_psql('postgres', q(VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) test));
> -detects_no_corruption("verify_heapam('test')",
> +detects_no_corruption(
> + "verify_heapam('test')",
> "all-frozen not corrupted table");
> corrupt_first_page('test');
> -detects_heap_corruption("verify_heapam('test')",
> +detects_heap_corruption(
> + "verify_heapam('test')",
> "all-frozen corrupted table");
> detects_no_corruption(
> "verify_heapam('test', skip := 'all-frozen')",
>
> although in some places it just wanted to insert a space, like this:
>
> @@ -77,9 +81,9 @@ print "standby 2: $result\n";
> is($result, qq(33|0|t), 'check streamed sequence content on standby 2');
>
> # Check that only READ-only queries can run on standbys
> -is($node_standby_1->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
> +is( $node_standby_1->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
> 3, 'read-only queries on standby 1');
> -is($node_standby_2->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
> +is( $node_standby_2->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
> 3, 'read-only queries on standby 2');
>
> # Tests for connection parameter target_session_attrs
>
>
> So I don't think we want that. Maybe in some future version it'll
> be more under control.
>
> Barring objections, I'll use the attached on Friday.
>
>

LGTM

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com