Re: Enable partitionwise join for partition keys wrapped by RelabelType

From: Jan Nidzwetzki <jan(at)planetscale(dot)com>
To: Matheus Alcantara <matheusssilv97(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Enable partitionwise join for partition keys wrapped by RelabelType
Date: 2026-09-01 22:47:46
Message-ID: 2b90ea1a-6cb2-406b-b450-274c8a1f9b7e@planetscale.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello Matheus,

On 01.09.26 23:20, Jan Nidzwetzki wrote:
> On 01.09.26 21:37, Matheus Alcantara wrote:
>> I think it's right, the citext case now plans as partial aggregation and
>> returns the correct single group. So v8 looks good to me.
> Thank you for reviewing and confirming. I ran additional tests on v8 and
> found no further issues. The patch series looks good to me as well.
Sorry for the extra round. I noticed that v8 does not pass the tests on
all platforms. The partition bounds 'A' and 'a' in the test I added sort
differently depending on the collation, which changes the order of the
Append children on macOS and Windows. Since the test type compares
case-insensitively, it also changes which of the two values is reported
for the group.

Attached is v9. It adds COLLATE "C" to the partition key of that test,
so the partition order is stable everywhere. This is a test-only change;
no code changed, and patches 1 to 3 are unmodified.

Best regards
Jan

--
Jan Nidzwetzki
PlanetScale Postgres Core Team

Attachment Content-Type Size
v9-0001-Fix-partition-pruning-for-partition-keys-wrapped-.patch text/plain 6.5 KB
v9-0002-Enable-partitionwise-join-for-partition-keys-wrap.patch text/plain 20.8 KB
v9-0003-Enable-partitionwise-join-for-outer-joins-on-Rela.patch text/plain 10.3 KB
v9-0004-Enable-full-partitionwise-aggregate-for-partition.patch text/plain 12.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2026-09-01 22:51:34 Re: EUC_* ILIKE index scan stopped matching seq scan in v19
Previous Message Michael Paquier 2026-09-01 22:38:06 Re: [PATCH] Speed up pg_waldump TAP test and fix some GitHub CI Windows flakiness