| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Petr Korobeinikov <pkorobeinikov(at)gmail(dot)com>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, Jeevan Chalke <jeevan(dot)chalke(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: psql :: support for \ev viewname and \sv viewname |
| Date: | 2016-05-04 00:35:43 |
| Message-ID: | 2b196506-e678-d22d-4cdb-ace77a884408@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5/3/16 3:10 PM, Dean Rasheed wrote:
> On 3 May 2016 at 16:52, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> I would change appendReloptionsArrayAH() to a function and keep AH as the
>> first argument (similar to other functions that take such a handle).
>
> I can understand changing it to a function, but I don't think AH
> should be the first argument. All other append*() functions that
> append to a buffer have the buffer as the first argument, including
> the appendStringLiteralAH() macro on which this is based.
Well, all the functions that take archive handles have that as the first
argument, so how do we consolidate that?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-05-04 01:38:52 | Re: pg_xlog -> pg_xjournal? |
| Previous Message | David Rowley | 2016-05-04 00:17:58 | Re: pg9.6 segfault using simple query (related to use fk for join estimates) |