| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, tomas(at)vondra(dot)me, hlinnaka(at)iki(dot)fi |
| Subject: | Re: Suggestions for improving \conninfo output in v18 |
| Date: | 2025-06-14 01:41:55 |
| Message-ID: | 2ab7121b-6c7d-493d-9008-ed440d92add5@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025/06/13 22:50, Nathan Bossart wrote:
> On Fri, Jun 13, 2025 at 06:52:26PM +0900, Fujii Masao wrote:
>> I've added the RMT to CC. What do you think about including the 0001 patch in v18?
>> Would you be okay with that?
>>
>> -----------------------
>> The 0001 patch changes \conninfo to report the full protocol version (e.g., 3.2)
>> instead of just the major version (e.g., 3). This is technically a behavior change,
>> but since protocol version 3.2 was introduced in v18, and both 3.0 and 3.2 are
>> now valid, always showing just "3" isn't very helpful. To see which protocol
>> version is actually in use, showing the full version is more informative.
>>
>> Therefore I see this as fixing an oversight in commit bba2fbc6238, so I'd like to
>> commit the 0001 patch as well in v18. Thought?
>> -----------------------
>
> Sounds good to me.
Thanks for confirming! I've now pushed the 0001 patch.
As discussed earlier, I've also committed the 0002 patch.
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2025-06-14 02:29:35 | Re: pg_dump --with-* options |
| Previous Message | Thomas Munro | 2025-06-13 23:15:25 | Re: [PING] [PATCH v2] parallel pg_restore: avoid disk seeks when jumping short distance forward |