| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | jesper(dot)pedersen(at)redhat(dot)com |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: partition tree inspection functions |
| Date: | 2018-07-31 02:11:27 |
| Message-ID: | 2ab396e6-9cad-f52f-1b1e-ace47aa82291@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Jesper,
On 2018/07/30 22:21, Jesper Pedersen wrote:
> On 07/30/2018 05:21 AM, Amit Langote wrote:
>>> As 0 is a valid return value for root nodes I think we should use -1
>>> instead for these cases.
>>
>> Makes sense, changed to be that way.
>>
>
> Looks good, the documentation for pg_partition_level could be expanded to
> describe the -1 scenario.
Done.
> New status: Ready for Committer
Thanks. Updated patch attached.
Regards,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Add-assorted-partition-reporting-functions.patch | text/plain | 27.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2018-07-31 02:51:04 | pg_default_acl missing 'n' case in doc |
| Previous Message | Etsuro Fujita | 2018-07-31 01:43:50 | Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. |