Re: PostgreSQL 10beta1 - compilation fails on OpenBSD -current

On 05/19/2017 12:03 PM, Pierre-Emmanuel André wrote:
> Hi,
>
> I tried to build PostgreSQL 10beta1 on OpenBSD -current and i have this error:
>
> gmake[3]: Entering directory '/usr/ports/pobj/postgresql-10beta1/postgresql-10beta1/src/backend/libpq'
> cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -O2 -pipe -I../../../src/include -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include -c -o be-fsstubs.o be-fsstubs.c
> cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -O2 -pipe -I../../../src/include -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include -c -o be-secure.o be-secure.c
> cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -O2 -pipe -I../../../src/include -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include -c -o auth.o auth.c
> auth.c: In function 'CheckBSDAuth':
> auth.c:2265: error: too few arguments to function 'sendAuthRequest'
>
>
> In auth.c, there is this call:
> /* Send regular password request to client, and get the response */
> sendAuthRequest(port, AUTH_REQ_PASSWORD);
>
> but this function is defined like this:
> static void sendAuthRequest(Port *port, AuthRequest areq, char *extradata,int extralen);

This was an oversight in my commit 8d3b9cce81c. It added those new
arguments, but didn't update that call. I'll go fix that, thanks for the
report!

You're the first to complain, and the buildfarm has been happy, so it
seems that you're the first one to try building 10beta1 with
--with-bsd-auth. We have one OpenBSD box in the buildfarm, "curculio",
but apparently it's not using the --with-bsd-auth option.

Mikael, could you add --with-bsd-auth to curculio's configuration,
please? On 9.6 and above.

- Heikki