Re: Using POPCNT and other advanced bit manipulation instructions

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org,Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>,David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>,PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>,Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Subject: Re: Using POPCNT and other advanced bit manipulation instructions
Date: 2019-02-13 19:44:49
Message-ID: 2F6CDF3B-08B9-4A15-ABDF-55D7F82AB76E@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On February 13, 2019 8:40:14 PM GMT+01:00, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>> I've pushed this now. Let's see what the buildfarm has to say about
>it.
>
>It's likely to be hard to tell, given the amount of pink from the Ryu
>patch. If Andrew is not planning to clean that up PDQ, I'd suggest
>reverting that patch pending having some repairs for it.

I'd assume that breaking bit counting would cause distinct enough damage (compile time or crashes). That's not to say that reverting ryu shouldn't be considered (although I'm not that bothered by cross version, ia64 and cygwin failures, especially because the latter two might be hard to come by outside the bf).

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-02-13 19:49:28 Re: Using POPCNT and other advanced bit manipulation instructions
Previous Message Tom Lane 2019-02-13 19:40:14 Re: Using POPCNT and other advanced bit manipulation instructions