| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH v1] Fix tab completion for REINDEX SYSTEM |
| Date: | 2026-10-27 07:50:42 |
| Message-ID: | 2EDD6783-C7E7-48DA-9801-E226F8AEEA49@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Oct 23, 2026, at 21:39, Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> wrote:
>
> Hi,
>
> psql currently offers `CONCURRENTLY` after `REINDEX SYSTEM`, although
> the backend rejects that combination [1].
>
> The attached patch completes only database names after `REINDEX SYSTEM`,
> including when parenthesized options are present.
>
> [1] https://github.com/postgres/postgres/blob/3138f248cd3de43dd0f96760fc666152ea8a5c37/src/backend/commands/indexcmds.c#L3317-L3321
>
> Kind regards,
> Sho Ito
>
> --
> =======================================
> Sho Ito (Sean)
>
> E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
> LinkedIn: https://www.linkedin.com/in/sho-ito-0628/
> GitHub: https://github.com/sean0628/
> =======================================
> <v1-0001-Fix-tab-completion-for-REINDEX-SYSTEM.patch>
LGTM. My local tests also show that v1 preserves the existing behavior for REINDEX DATABASE while removing the unsupported CONCURRENTLY suggestion for REINDEX SYSTEM.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2026-10-27 07:57:56 | Re: Don't close relation files when the visibility map is extended |
| Previous Message | Henson Choi | 2026-10-27 07:11:44 | Re: [PATCH] Consider window functions when reordering GROUP BY items |