| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Predefined role pg_maintenance for VACUUM, ANALYZE, CHECKPOINT. |
| Date: | 2021-11-02 17:45:49 |
| Message-ID: | 2E63F740-B422-40A8-B8B0-28CDD5FEF41F@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/2/21, 10:29 AM, "Jeff Davis" <pgsql(at)j-davis(dot)com> wrote:
> Great idea! Patch attached.
>
> This feels like a good pattern that we might want to use elsewhere, if
> the need arises.
The approach in the patch looks alright to me, but another one could
be to build a SelectStmt when parsing CHECKPOINT. I think that'd
simplify the standard_ProcessUtility() changes.
Otherwise, I see a couple of warnings when compiling:
xlogfuncs.c:54: warning: implicit declaration of function ‘RequestCheckpoint’
xlogfuncs.c:56: warning: control reaches end of non-void function
Nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-11-02 18:17:05 | Re: make tuplestore helper function |
| Previous Message | Tom Lane | 2021-11-02 17:43:46 | Re: Eval expression R/O once time (src/backend/executor/execExpr.c) |