| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Allow tests to pass in OpenSSL FIPS mode |
| Date: | 2023-03-06 16:06:22 |
| Message-ID: | 2E4CC165-F3F1-4E5A-AA10-2025870AC3A7@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 6 Mar 2023, at 15:55, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> For readers without all context, wouldn't it be better to encode in the
>> function name why we're not just calling a hash like md5? Something like
>> fips_allowed_hash() or similar?
>
> I'd prefer shorter than that --- all these queries are laid out on the
> expectation of a very short function name. Maybe "fipshash()"?
>
> We could make the comment introducing the function declarations more
> elaborate, too.
fipshash() with an explanatory comments sounds like a good idea.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2023-03-06 16:07:07 | Re: a very minor bug and a couple of comment changes for basebackup.c |
| Previous Message | John Naylor | 2023-03-06 16:00:52 | Re: [PoC] Improve dead tuple storage for lazy vacuum |