| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | Martijn van Oosterhout <kleptog(at)svana(dot)org>, pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: Faster StrNCpy |
| Date: | 2006-09-26 21:12:25 |
| Message-ID: | 29984.1159305145@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Neil Conway <neilc(at)samurai(dot)com> writes:
> A wholesale replacement of strncpy() calls is probably worth doing --
> replacing them with strlcpy() if the source string is NUL-terminated,
> and I suppose memcpy() otherwise.
What I'd like to do immediately is put in strlcpy() and hit the two or
three places I think are performance-relevant. I agree with trying to
get rid of StrNCpy/strncpy calls over the long run, but it's just code
beautification and probably not appropriate for beta.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | luis garcia | 2006-09-26 21:25:48 | Constant changes (Re-Build) |
| Previous Message | Tom Lane | 2006-09-26 21:04:14 | Re: Faster StrNCpy |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2006-09-27 00:42:20 | Re: Faster StrNCpy |
| Previous Message | Tom Lane | 2006-09-26 21:04:14 | Re: Faster StrNCpy |