Re: pgsql: Further dtrace adjustments for the backend-IDs-in-relpath patch.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Further dtrace adjustments for the backend-IDs-in-relpath patch.
Date: 2010-08-14 16:35:15
Message-ID: 29973.1281803715@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

rhaas(at)postgresql(dot)org (Robert Haas) writes:
> Further dtrace adjustments for the backend-IDs-in-relpath patch.

Hrm, this doesn't look right at all. The documentation now advertises
that backendid is passed to a number of probes that the code isn't
actually doing that for. I agree with the changes proposed by the
docs changes, and would suggest that buffer-flush-start,
buffer-flush-done, buffer-write-dirty-start, and buffer-write-dirty-done
probes probably need to get the backendid too. But in any case the
code isn't matching the docs in HEAD.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-08-14 21:58:30 Re: pgsql: Further dtrace adjustments for the backend-IDs-in-relpath patch.
Previous Message Tom Lane 2010-08-14 15:47:30 pgsql: Fix planner to make a reasonable assumption about the amount of