Re: Small race in pg_xlogdump --follow

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small race in pg_xlogdump --follow
Date: 2016-09-26 13:44:18
Message-ID: 29847.1474897458@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Attached patch puts a retry loop around opening the file that retries for 5
> seconds (which is excessive, but should be safe) in case the file is
> missing (and still fails out for other error messages of course).

> Comments?

The patch assumes that pg_usleep won't change errno, an assumption
I have little faith in.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeevan Ladhe 2016-09-26 13:45:02 Re: pgbench more operators & functions
Previous Message Magnus Hagander 2016-09-26 13:37:38 Small race in pg_xlogdump --follow