| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com> |
| Subject: | Re: No-op case in ExecEvalConvertRowtype |
| Date: | 2017-04-07 03:32:45 |
| Message-ID: | 29819.1491535965@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> writes:
> While I agree that we can remove indesc->tdtypeid ==
> outdesc->tdtypeid, I am not sure whether it should be replaced by
> !indesc->tdhasoid && !outdesc->tdhasoid.
No, that was overly conservative; the correct test is that the tdhasoid
settings must be equal. Reading Robert's commit message for 3838074f8
and mine for 3f902354b might clarify this.
> If that's required, it seems
> to be a bug that needs to be fixed in earlier braches as well.
It's not a bug in older branches, because the tdtypeid comparison
was enough to guarantee the same tdhasoid values.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2017-04-07 03:58:24 | Re: Faster methods for getting SPI results (460% improvement) |
| Previous Message | Tom Lane | 2017-04-07 03:20:11 | Re: src/interfaces/libpq shipping nmake-related Makefiles |