Re: Re: [COMMITTERS] pgsql: Invent a memory context reset/delete callback mechanism.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Subject: Re: Re: [COMMITTERS] pgsql: Invent a memory context reset/delete callback mechanism.
Date: 2015-02-28 01:42:47
Message-ID: 29787.1425087767@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> On Fri, 2015-02-27 at 22:17 +0000, Tom Lane wrote:
>> In passing, per discussion, rearrange some boolean fields in struct
>> MemoryContextData so as to avoid wasted padding space. For safety,
>> this requires making allowInCritSection's existence unconditional;
>> but I think that's a better approach than what was there anyway.

> I notice that this uses the bytes in MemoryContextData that I was hoping
> to use for the memory accounting patch (for memory-bounded HashAgg).

Meh. I thought Andres' complaint about that was unfounded anyway ;-).
But I don't really see why a memory accounting patch should be expected to
have zero footprint.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2015-02-28 02:16:23 Re: Re: [COMMITTERS] pgsql: Invent a memory context reset/delete callback mechanism.
Previous Message Tom Lane 2015-02-28 01:34:16 Re: pgsql: Invent a memory context reset/delete callback mechanism.

Browse pgsql-hackers by date

  From Date Subject
Next Message Gavin Flower 2015-02-28 01:53:51 Re: logical column ordering
Previous Message Tom Lane 2015-02-28 01:40:18 Re: Providing catalog view to pg_hba.conf file - Patch submission