| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Dave Page <dpage(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv |
| Date: | 2017-03-19 21:40:22 |
| Message-ID: | 2970.1489959622@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> On 03/17/2017 07:57 PM, Tom Lane wrote:
>> This seems to have broken narwhal:
> It's not very nice to change the requirements in a minor version, but I
> don't think this would be a real problem for anyone. Not many people
> build PostgreSQL using MinGW, let alone with an ancient version of it.
> But if people don't agree, we could instead revert this patch and apply
> the smaller V2 patch [2] instead, in the back-branches.
> Thoughts? Any objections to requiring a newer version of MinGW? Any
> objections to do so in the next minor release?
Hm. I'm +1 for doing that in HEAD, but less so for the back branches.
Can we get some fix on when the functions in question were added
to MinGW? If we knew how new a toolchain we'd be requiring here,
that would help make this decision.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-03-20 00:32:06 | Re: [COMMITTERS] pgsql: Add TAP tests for password-based authentication methods. |
| Previous Message | Heikki Linnakangas | 2017-03-19 21:26:40 | Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Karlsson | 2017-03-19 22:31:57 | Re: ICU integration |
| Previous Message | Heikki Linnakangas | 2017-03-19 21:26:40 | Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv |