| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Move test_fsync to /contrib. |
| Date: | 2011-01-22 20:03:21 |
| Message-ID: | 29691.1295726601@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
I wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Why does pg_test_fsync.c include postgres.h? Shouldn't it use postgres_fe.h?
> I had tried that, actually, but it fails because the other include files
> test_fsync needs are backend-specific. We may have to refactor those
> include files so that the stuff test_fsync actually needs is includable
> with less context required.
On closer inspection, test_fsync doesn't even need the include files
that caused the problem. I think my latest commit will fix everything.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2011-01-22 20:14:36 | pgsql: Get rid of the global variable holding the error state |
| Previous Message | Tom Lane | 2011-01-22 20:01:54 | pgsql: More pg_test_fsync fixups. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2011-01-22 20:14:36 | pgsql: Get rid of the global variable holding the error state |
| Previous Message | Andrew Dunstan | 2011-01-22 19:52:01 | Re: plpython versus gcc 4.5.x |