Re: Remove pg_am.amindexnulls?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Remove pg_am.amindexnulls?
Date: 2011-01-08 01:20:33
Message-ID: 29674.1294449633@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Fetter <david(at)fetter(dot)org> writes:
> On Fri, Jan 07, 2011 at 08:08:38PM -0500, Tom Lane wrote:
>> Anyone against simplifying matters by getting rid of
>> pg_am.amindexnulls?

> I guess the only potential use for it would be for some kind of am
> that *couldn't* index nulls out of the gate. Might their be such AMs
> on the horizon?

Well, there are AMs around already that can't index nulls: hash is one,
and GIN was one until an hour ago. The question though is whether
anything outside the AM needs to know about that behavior. Between
amclusterable, amsearchnulls, and amoptionalkey, I believe that we have
quite enough flags already to cover what anything else actually
needs-to-know about the AM's behavior.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2011-01-08 01:24:28 Re: Fixing GIN for empty/null/full-scan cases
Previous Message Greg Smith 2011-01-08 01:15:12 Re: We need to log aborted autovacuums