Re: remembering locks and dynahash.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: remembering locks and dynahash.c
Date: 2012-05-31 06:06:43
Message-ID: 29637.1338444403@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
> I am working on making resource owner remember a limited number of
> locks, so it can reassign them more efficiently.

Check, per previous discussion.

> Currently I'm having resowner.c remember the LOCALLOCKTAG, because I
> thought that that was the only handle I could use. But now I'm
> wondering if I should remember the LOCALLOCK * instead.

I was envisioning LOCALLOCK *. dynahash will never move an existing
entry, and if the entry can be deleted while the resowner still holds a
pointer to it then you've got a logic bug.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Devrim GÜNDÜZ 2012-05-31 06:21:03 Re: Uppercase tab completion keywords in psql?
Previous Message Tom Lane 2012-05-31 05:40:50 Re: Bug in new buffering GiST build code