Re: pg_tablespace_location() error message

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_tablespace_location() error message
Date: 2012-04-10 23:09:33
Message-ID: 29593.1334099373@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Tue, Apr 10, 2012 at 06:16:31PM -0400, Robert Haas wrote:
>> On Tue, Apr 10, 2012 at 5:43 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> The way the function is coded, it has no need to look into pg_tablespace
>>> as such, which is why you don't get something like "no such tablespace".

>> I think what Bruce might be getting at is that 0 is more likely than a
>> randomly chosen value to be passed to this function; for example, one
>> can imagine wanting to pass pg_class.reltablespace.

> Yes, that was my point.

Hm. I have no objection to special-casing zero here, but what behavior
do you want? Should it return an empty string as we do for
DEFAULTTABLESPACE_OID, or throw a different error?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-04-10 23:14:51 Re: invalid search_path complaints
Previous Message Greg Smith 2012-04-10 23:02:05 Re: Last gasp