| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Adminpack build fix |
| Date: | 2006-10-19 17:47:21 |
| Message-ID: | 29576.1161280041@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
>> The reason for redeclaring these in the contrib files is to
>> get DLLIMPORT onto them...
> Interedting - it builds on MSVC without it :-O
> Anyway. That certainly explains why MSVC is complaining - it's getting
> completely different definitions of these variables from the header and
> from the actual file.
The same redeclaration technique is being used elsewhere (pg_buffercache
and pg_freespacemap it looks like). Aren't you getting warnings there
too?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2006-10-19 17:49:00 | qsort vs MSVC build |
| Previous Message | Magnus Hagander | 2006-10-19 17:44:42 | Re: Adminpack build fix |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2006-10-19 17:49:41 | Re: Adminpack build fix |
| Previous Message | Magnus Hagander | 2006-10-19 17:44:42 | Re: Adminpack build fix |