| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: make \d pg_toast.foo show its indices ; and, \d toast show its main table ; and \d relkind=I show its partitions |
| Date: | 2019-07-23 21:08:38 |
| Message-ID: | 29546.1563916118@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
> Field relnamespace oid in pg_class appears with pg 7.3, maybe it would be
> appropriate to guard agains older versions, with "pset.sversion >= 70300".
> It seems that there are other unguarded instances in "describe.c", so
> maybe this is considered too old.
Per the comment at the head of describe.c, we only expect it to work
back to 7.4. I tested against a 7.4 server, the modified queries
seem fine.
> Marked as ready.
Pushed with minor fiddling with the toast-table code, and rather
more significant hacking on the partitioned-index code. Notably,
0003 had broken output of Tablespace: footers for everything except
indexes. It's possibly not Justin's fault that that wasn't noticed,
because we had no regression tests covering it :-(. We do now.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2019-07-23 21:10:41 | Re: stress test for parallel workers |
| Previous Message | Jehan-Guillaume de Rorthais | 2019-07-23 21:01:43 | Re: Fetching timeline during recovery |