Re: BUG #3674: Unnecessary checkpoints by WAL Writer

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "ITAGAKI Takahiro" <itagaki(dot)takahiro(at)gmail(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #3674: Unnecessary checkpoints by WAL Writer
Date: 2007-10-12 17:06:42
Message-ID: 29496.1192208802@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

"ITAGAKI Takahiro" <itagaki(dot)takahiro(at)gmail(dot)com> writes:
> WAL Writer requests unnecessary checkpoints with CHECKPOINT_CAUSE_XLOG.
> RedoRecPtr, declared in xlog.c, is initialized at StartupXLOG() but never
> updated in WAL Writer because it never calls XLogInsert(). It judges excess
> of segments wrongly.

Good catch. I think the best fix for this is to make XLogWrite call
GetRedoRecPtr and recheck the condition before actually sending a
signal.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Martin Pitt 2007-10-12 17:08:19 Re: libpq5 8.3 breaks 8.2 compatibility with encodings
Previous Message Heikki Linnakangas 2007-10-12 17:00:36 Re: libpq5 8.3 breaks 8.2 compatibility with encodings