Re: use-regular-expressions-to-simplify-less_greater-and-not_equals.patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: 孙诗浩(思才) <sunshihao(dot)ssh(at)alibaba-inc(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, 范孝剑(康贤) <funnyxj(dot)fxj(at)alibaba-inc(dot)com>
Subject: Re: use-regular-expressions-to-simplify-less_greater-and-not_equals.patch
Date: 2021-09-05 20:11:14
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 8/10/21 11:27 PM, 孙诗浩(思才) wrote:
>>      we can use regular expressions (<>|!=) to cover "<>" and "!=".

> I don't understand the problem being solved here. This looks like a
> change with no discernable benefit. I don't agree that the current code
> is substantially more likely to confuse developers. And the lexer is not
> something that gets a lot of change.

By my count, the response to this has been two definite "no"s, one
leaning-to-no, and nobody speaking in favor. Nor has the submitter
provided a stronger argument for it. I'm going to mark this
rejected in the CF app.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-09-05 20:28:00 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
Previous Message Tom Lane 2021-09-05 19:57:52 Re: Fix pkg-config file for static linking