Re: pg_upgrade fails to detect unsupported arrays and ranges

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Subject: Re: pg_upgrade fails to detect unsupported arrays and ranges
Date: 2021-04-28 21:44:15
Message-ID: 2942991.1619646255@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> On 28 Apr 2021, at 22:47, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> This wording is copied-and-pasted from the other similar tests. I agree
>> that it's advocating a solution that might be overkill, but if we change
>> it we should also change the existing messages.

> Good point.

>> I don't mind doing that in HEAD; less sure about the back branches, as

> I think it would be helpful for users to try and give slightly more expanded
> advice while (obviously) still always being safe. I’m happy to take a crack at
> that once back unless someone beats me to it.

Seems like s/remove the problem tables/drop the problem columns/
is easy and sufficient.

>> (I think) these are translatable strings.

> If they aren't I think we should try and make them so to as far as we can
> reduce language barrier problems in such important messages.

Checking, I see they do appear in pg_upgrade's po files. So I propose
that we change the existing messages in HEAD but not the back branches.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2021-04-28 21:55:54 Re: SQL/JSON: functions
Previous Message Daniel Gustafsson 2021-04-28 20:58:01 Re: pg_upgrade fails to detect unsupported arrays and ranges