| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Subject: | Re: btvacuumpage useless "orig_blkno" |
| Date: | 2011-11-22 02:14:58 |
| Message-ID: | 29399.1321928098@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Excerpts from Simon Riggs's message of lun nov 21 19:11:21 -0300 2011:
>> tail recursion - read comments at bottom of the function
> Right, but we don't need to pass the value as a parameter, we can just
> save it at the start of the function, as my proposed patch does, right?
If you do this, it's not really tail recursion anymore, so the comments
need to be adjusted. The patch sounds reasonable, but you have more
work to do to fix the comments ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-11-22 02:24:38 | Re: Removing postgres -f command line option |
| Previous Message | Tom Lane | 2011-11-22 01:54:31 | Re: EXPLAIN (plan off, rewrite off) for benchmarking |